Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting specific priority queue depth or rate #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Setting specific priority queue depth or rate #566

wants to merge 1 commit into from

Conversation

edgar-costa
Copy link

@edgar-costa edgar-costa commented Mar 17, 2018 •
edited
Loading

Add a method to set the depth or rate of priority queues in the simple switch. At the moment the sswitch_CLI.py is using set_egress_queue_depth/rate to set the rate/depth of a given port but there was not way to set if for an individual priority queue.

This patch adds:

  • set_egress_priority_queue_depth/rate in the simple_switch implementation
  • Updated thrift files
  • Modified do_set_queue_depth/rate from sswitch_CLI.py so they call the new functions when a priority is provided. Also added exception catchers when the parameters are not integers.

Update: I realized that this will not build if the multiqueueing is not enabled at compile time. This is because QueueingLogicRL does not know about priorities. What would be the right way to proceed?

#ifdef SSWITCH_PRIORITY_QUEUEING_ON
  bm::QueueingLogicPriRL<std::unique_ptr<Packet>, EgressThreadMapper>
#else
  bm::QueueingLogicRL<std::unique_ptr<Packet>, EgressThreadMapper>
#endif

@antoninbas
Copy link
Member

Hi,
Thanks for opening this PR. Are you or your organization members of p4.org? We can only accept contributions from members.
Thanks.

@edgar-costa
Copy link
Author

Hi Antonin,

Either me or my organization are members of the p4.org. However I already contacted my University and we started the procedure from: https://p4.org/join/.

What should I do once we are members?

@antoninbas
Copy link
Member

Once you are members, I will get notified (although you can also let me know when the procedure is done). I can then review your PR & merge it.

@drobinkent
Copy link

Is the suuport for setting rate for priority queus available now?

@edgar-costa edgar-costa mentioned this pull request Jun 7, 2020
Closed
Base automatically changed from master to main February 9, 2021 02:44
@edgar-costa edgar-costa mentioned this pull request Apr 16, 2022
Closed
@jafingerhut
Copy link
Contributor

@sys-ptipu I am hoping by @'ing this Github id, a person respnosible for the (so far) three comments made recently will notice and respond. We would like to know how many PRs you plan to create such comments for in the future. If only three, no problem, but if all open PRs on repositories under https://github.com/p4lang, that would be a lot of "noise" in the PR comments, and it would be great if you might find a different way of recording this information.

@jafingerhut
Copy link
Contributor

I believe that the original intent of this issue, which I believe was to enable setting the depth and rate of individual priority queues, might be implemented now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgar-costa @antoninbas @drobinkent @jafingerhut